pkg/polymer_expressions/lib/polymer_expressions.dart - Issue 310903003: Don’t throw on assignments to non-assignable expressions. Allow non-literal indices in assignable e…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/polymer_expressions/lib/polymer_expressions.dart

Issue 310903003: Don’t throw on assignments to non-assignable expressions. Allow non-literal indices in assignable e… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/polymer_expressions/lib/polymer_expressions.dart

diff --git a/pkg/polymer_expressions/lib/polymer_expressions.dart b/pkg/polymer_expressions/lib/polymer_expressions.dart

index 32ddd0ea67e156517754e12e76261c427b5b0114..fa03dee25ce874b484265631f68b2962ab40087c 100644

--- a/pkg/polymer_expressions/lib/polymer_expressions.dart

+++ b/pkg/polymer_expressions/lib/polymer_expressions.dart

@@ -299,7 +299,7 @@ class _Binding extends Bindable {

set value(v) {

try {

- var newValue = assign(_expr, v, _scope);

+ var newValue = assign(_expr, v, _scope, checkAssignability: false);

_check(newValue, skipChanges: true);

} catch (e, s) {

new Completer().completeError(

« no previous file with comments | « pkg/polymer_expressions/lib/eval.dart ('k') | pkg/polymer_expressions/test/eval_test.dart » ('j') | no next file with comments »