Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: content/child/npapi/np_channel_base.cc

Issue 310853003: Add IPC::ChannelProxy::Create() and IPC::SyncChannel::Create() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/npapi/np_channel_base.cc
diff --git a/content/child/npapi/np_channel_base.cc b/content/child/npapi/np_channel_base.cc
index 76845bd8f21a9707079d201782c4ea9414747157..d4b02ff1dd3bc64e7bac8e48c2ff03382bf4b0bc 100644
--- a/content/child/npapi/np_channel_base.cc
+++ b/content/child/npapi/np_channel_base.cc
@@ -178,9 +178,8 @@ bool NPChannelBase::Init(base::MessageLoopProxy* ipc_message_loop,
return false;
#endif
- channel_.reset(new IPC::SyncChannel(
- channel_handle_, mode_, this, ipc_message_loop, create_pipe_now,
- shutdown_event));
+ channel_ = IPC::SyncChannel::Create(this, ipc_message_loop, shutdown_event);
jam 2014/06/03 17:30:41 why not use the Create method with 6 parameters as
Hajime Morrita 2014/06/03 18:01:59 Done.
+ channel_->Init(channel_handle_, mode_, create_pipe_now);
#if defined(OS_POSIX)
// Check the validity of fd for bug investigation. Remove after fixed.

Powered by Google App Engine
This is Rietveld 408576698