Add IPC::ChannelProxy::Create() and IPC::SyncChannel::Create()

ipc/ipc_channel_proxy.h

Index: ipc/ipc_channel_proxy.h
diff --git a/ipc/ipc_channel_proxy.h b/ipc/ipc_channel_proxy.h
index 0a3a5d2fb05b480d356c8a66e731045295f554ba..cd539d081546b4fbba9e562d6415d653f26cf809 100644
--- a/ipc/ipc_channel_proxy.h
+++ b/ipc/ipc_channel_proxy.h
@@ -64,10 +64,16 @@ class IPC_EXPORT ChannelProxy : public Sender, public base::NonThreadSafe {
   // on the background thread.  Any message not handled by the filter will be
   // dispatched to the listener.  The given task runner correspond to a thread
   // on which IPC::Channel is created and used (e.g. IO thread).
-  ChannelProxy(const IPC::ChannelHandle& channel_handle,
-               Channel::Mode mode,
-               Listener* listener,
-               base::SingleThreadTaskRunner* ipc_task_runner);
+  static scoped_ptr<ChannelProxy> Create(
+      const IPC::ChannelHandle& channel_handle,
+      Channel::Mode mode,
+      Listener* listener,
+      base::SingleThreadTaskRunner* ipc_task_runner);
+
+  // This Create() does not create underlying channel and let Init() do it.

[jam, 2014/06/03 17:30:41]

i dont think this is needed if the other code where i commented stays the same
as before

[Hajime Morrita, 2014/06/03 18:01:59]

Unfortunately we cannot remove this as ppapi_dispatcher.cc is using it.
That's why SyncChannel had two separate constructors.

[jam, 2014/06/03 20:37:31]

ah you're right, what about the ChannelProxy::Create though? SyncChannel is
using the constructor and not the second new create method you added there?

+  static scoped_ptr<ChannelProxy> Create(
+      Listener* listener,
+      base::SingleThreadTaskRunner* ipc_task_runner);
 
   virtual ~ChannelProxy();
 
@@ -124,6 +130,9 @@ class IPC_EXPORT ChannelProxy : public Sender, public base::NonThreadSafe {
   // to the internal state.
   ChannelProxy(Context* context);
 
+  ChannelProxy(Listener* listener,
+               base::SingleThreadTaskRunner* ipc_task_runner);
+
   // Used internally to hold state that is referenced on the IPC thread.
   class Context : public base::RefCountedThreadSafe<Context>,
                   public Listener {