Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: Source/bindings/core/v8/generated.gyp

Issue 310563004: IDL build: Split global constructors into core and modules (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Tweak (reupload) Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/generated.gyp
diff --git a/Source/bindings/core/v8/generated.gyp b/Source/bindings/core/v8/generated.gyp
index 52ba2840dcd9ddf66e0255397b05c6d46fe2c05b..44dfd1601b6c65a7cfc9db2b003604bc2052ff6c 100644
--- a/Source/bindings/core/v8/generated.gyp
+++ b/Source/bindings/core/v8/generated.gyp
@@ -9,24 +9,19 @@
{
'includes': [
'../../../core/core.gypi',
+ # FIXME: shouldn't depend on modules http://crbug.com/358074
+ '../../../modules/modules.gypi',
'../../bindings.gypi',
- # FIXME: need list of modules IDL files because some core IDL files depend
- # on modules IDL files http://crbug.com/358074
- '../../modules/idl.gypi',
# FIXME: need info about modules IDL files because some core IDL files
# depend on modules IDL files http://crbug.com/358074
+ '../../modules/idl.gypi',
'../../modules/modules.gypi',
'../../scripts/scripts.gypi',
+ '../generated.gypi',
'../idl.gypi',
'generated.gypi',
],
- # Write lists of main IDL files to a file, so that the command lines don't
- # exceed OS length limits.
- 'variables': {
- 'core_idl_files_list': '<|(core_idl_files_list.tmp <@(core_idl_files))',
- },
-
'targets': [
################################################################################
{
@@ -37,6 +32,10 @@
'hard_dependency': 1,
'dependencies': [
haraken 2014/06/02 15:45:14 Just a question about GYP: What is "dependencies"?
Nils Barth (inactive) 2014/06/03 01:47:50 Short answer: 'dependencies': This lists other tar
'../../../core/core_generated.gyp:generated_testing_idls',
+ '../generated.gyp:core_global_constructors_idls',
+ # FIXME: should not depend on modules, but partial interface definitions
+ # in modules change bindings for core http://crbug.com/358074
+ '../generated.gyp:modules_global_constructors_idls',
'<(bindings_scripts_dir)/scripts.gyp:cached_jinja_templates',
'<(bindings_scripts_dir)/scripts.gyp:cached_lex_yacc_tables',
# FIXME: should be interfaces_info_core (w/o modules)

Powered by Google App Engine
This is Rietveld 408576698