Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: Source/bindings/core/core.gypi

Issue 310563004: IDL build: Split global constructors into core and modules (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Tweak (reupload) Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/core.gypi
diff --git a/Source/bindings/core/core.gypi b/Source/bindings/core/core.gypi
index f98bc08d6a0299a5f1562c3aef255bec330b26cf..ba66ed2501b8f5d5b817aa93ad0992b22381092c 100644
--- a/Source/bindings/core/core.gypi
+++ b/Source/bindings/core/core.gypi
@@ -4,12 +4,11 @@
{
'includes': [
- '../bindings.gypi', # FIXME: factor out bindings_core http://crbug.com/358074
- '../modules/v8/generated.gypi', # FIXME: remove once bindings CG generates qualified includes http://crbug.com/377364
+ '../modules/v8/generated.gypi', # FIXME: remove once core script generate qualified includes correctly: http://crbug.com/358074
haraken 2014/06/02 15:45:14 generate => generates
Nils Barth (inactive) 2014/06/03 01:47:50 actually should be 'core script' => 'core script*s
'v8/generated.gypi',
],
'variables': {
- 'bindings_core_output_dir': '<(bindings_output_dir)/core',
+ 'bindings_core_output_dir': '<(SHARED_INTERMEDIATE_DIR)/bindings/core',
},
}

Powered by Google App Engine
This is Rietveld 408576698