Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: Source/bindings/generated.gyp

Issue 310563004: IDL build: Split global constructors into core and modules (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Tweak (reupload) Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/generated.gyp
diff --git a/Source/bindings/generated.gyp b/Source/bindings/generated.gyp
index 1acc819efa4dd290931ef6fdb0d8ce7d07f73a7e..dffafc0f6564e4e860044aa5ad4509559303021c 100644
--- a/Source/bindings/generated.gyp
+++ b/Source/bindings/generated.gyp
@@ -73,62 +73,5 @@
}]
},
################################################################################
- {
- # FIXME: Global constructors are used by bindings_core (e.g., V8Window.cpp)
- # but depend on modules, which violates layering http://crbug.com/358074
- # FIXME: Generate separate core_global_constructors_idls
- # http://crbug.com/358074
- 'target_name': 'global_constructors_idls',
- 'type': 'none',
- 'dependencies': [
- 'global_objects',
- ],
- 'actions': [{
- 'action_name': 'generate_global_constructors_idls',
- 'inputs': [
- 'scripts/generate_global_constructors.py',
- 'scripts/utilities.py',
- # Only includes main IDL files (exclude dependencies and testing,
- # which should not appear on global objects).
- '<(main_interface_idl_files_list)',
- '<@(main_interface_idl_files)',
- '<(bindings_output_dir)/GlobalObjects.pickle',
- ],
- 'outputs': [
- '<@(generated_global_constructors_idl_files)',
- '<@(generated_global_constructors_header_files)',
- ],
- 'action': [
- 'python',
- 'scripts/generate_global_constructors.py',
- '--idl-files-list',
- '<(main_interface_idl_files_list)',
- '--global-objects-file',
- '<(bindings_output_dir)/GlobalObjects.pickle',
- '--write-file-only-if-changed',
- '<(write_file_only_if_changed)',
- '--',
- 'Window',
- '<(blink_output_dir)/WindowConstructors.idl',
- 'SharedWorkerGlobalScope',
- '<(blink_output_dir)/SharedWorkerGlobalScopeConstructors.idl',
- 'DedicatedWorkerGlobalScope',
- '<(blink_output_dir)/DedicatedWorkerGlobalScopeConstructors.idl',
- 'ServiceWorkerGlobalScope',
- '<(blink_output_dir)/ServiceWorkerGlobalScopeConstructors.idl',
- ],
- 'message': 'Generating IDL files for constructors on global objects',
- }]
- },
-################################################################################
- {
- 'target_name': 'generated_idls',
- 'type': 'none',
- 'dependencies': [
- '../core/core_generated.gyp:generated_testing_idls',
- 'global_constructors_idls',
- ],
- }
-################################################################################
], # targets
}

Powered by Google App Engine
This is Rietveld 408576698