Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: Source/core/frame/SmartClip.cpp

Issue 310353003: Oilpan: Replace RefPtrs and raw pointers to Node and its subclasses in core/frame and core/page wit… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/SmartClip.h ('k') | Source/core/page/DragController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/SmartClip.cpp
diff --git a/Source/core/frame/SmartClip.cpp b/Source/core/frame/SmartClip.cpp
index 3a95095c06e4ef057ba19fe6b31f9962b2223556..d9a077e20d12ebf7a8603f80b4858d0a49b39a33 100644
--- a/Source/core/frame/SmartClip.cpp
+++ b/Source/core/frame/SmartClip.cpp
@@ -70,7 +70,7 @@ static Node* nodeInsideFrame(Node* node)
// read/write code in one place!
String SmartClipData::toString()
{
- if (!m_node)
+ if (m_isEmpty)
return emptyString();
const UChar fieldSeparator = 0xFFFE;
@@ -109,7 +109,7 @@ SmartClipData SmartClip::dataForRect(const IntRect& cropRect)
bestNode = bestNodeInFrame;
}
- Vector<Node*> hitNodes;
+ WillBeHeapVector<RawPtrWillBeMember<Node> > hitNodes;
collectOverlappingChildNodes(bestNode, resizedCropRect, hitNodes);
if (hitNodes.isEmpty() || hitNodes.size() == bestNode->countChildren()) {
@@ -237,7 +237,7 @@ bool SmartClip::shouldSkipBackgroundImage(Node* node)
return false;
}
-void SmartClip::collectOverlappingChildNodes(Node* parentNode, const IntRect& cropRect, Vector<Node*>& hitNodes)
+void SmartClip::collectOverlappingChildNodes(Node* parentNode, const IntRect& cropRect, WillBeHeapVector<RawPtrWillBeMember<Node> >& hitNodes)
{
if (!parentNode)
return;
« no previous file with comments | « Source/core/frame/SmartClip.h ('k') | Source/core/page/DragController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698