Oilpan: Replace RefPtrs and raw pointers to Node and its subclasses in core/frame and core/page wit…

Source/core/frame/SmartClip.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 52 matching lines @@
 
 // FIXME: SmartClipData is eventually returned via
 // SLookSmartClip.DataExtractionListener:
 // http://img-developer.samsung.com/onlinedocs/sms/com/samsung/android/sdk/look/...
 // however the original author of this change chose to use a string-serialization
 // format (presumably to make IPC easy?).
 // If we're going to use this as a Pickle format, we should at least have the
 // read/write code in one place!
 String SmartClipData::toString()
 {
-    if (!m_node)
+    if (m_isEmpty)
         return emptyString();
 
     const UChar fieldSeparator = 0xFFFE;
     const UChar rowSeparator = 0xFFFF;
 
     StringBuilder result;
     result.append(String::number(m_rect.x()));
     result.append(fieldSeparator);
     result.append(String::number(m_rect.y()));
     result.append(fieldSeparator);
@@ skipping 18 matching lines @@
     Node* bestNode = findBestOverlappingNode(m_frame->document(), resizedCropRect);
     if (!bestNode)
         return SmartClipData();
 
     if (Node* nodeFromFrame = nodeInsideFrame(bestNode)) {
         // FIXME: This code only hit-tests a single iframe. It seems like we ought support nested frames.
         if (Node* bestNodeInFrame = findBestOverlappingNode(nodeFromFrame, resizedCropRect))
             bestNode = bestNodeInFrame;
     }
 
-    Vector<Node*> hitNodes;
+    WillBeHeapVector<RawPtrWillBeMember<Node> > hitNodes;
     collectOverlappingChildNodes(bestNode, resizedCropRect, hitNodes);
 
     if (hitNodes.isEmpty() || hitNodes.size() == bestNode->countChildren()) {
         hitNodes.clear();
         hitNodes.append(bestNode);
     }
 
     // Unite won't work with the empty rect, so we initialize to the first rect.
     IntRect unitedRects = hitNodes[0]->pixelSnappedBoundingBox();
     StringBuilder collectedText;
@@ skipping 107 matching lines @@
     // image out of a CSS background, you're probably going to specify a height
     // or a width. On the other hand, if we've got a legit background image,
     // it's very likely the height or the width will be set to auto.
     RenderObject* renderer = node->renderer();
     if (renderer && (renderer->style()->logicalHeight().isAuto() || renderer->style()->logicalWidth().isAuto()))
         return true;
 
     return false;
 }
 
-void SmartClip::collectOverlappingChildNodes(Node* parentNode, const IntRect& cropRect, Vector<Node*>& hitNodes)
+void SmartClip::collectOverlappingChildNodes(Node* parentNode, const IntRect& cropRect, WillBeHeapVector<RawPtrWillBeMember<Node> >& hitNodes)
 {
     if (!parentNode)
         return;
     IntRect resizedCropRect = parentNode->document().view()->windowToContents(cropRect);
     for (Node* child = parentNode->firstChild(); child; child = child->nextSibling()) {
         IntRect childRect = child->pixelSnappedBoundingBox();
         if (resizedCropRect.intersects(childRect))
             hitNodes.append(child);
     }
 }
@@ skipping 36 matching lines @@
 
                 result.append(nodeValue);
             }
         }
     }
 
     return result.toString();
 }
 
 } // namespace WebCore