Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Unified Diff: Source/core/frame/SmartClip.h

Issue 310353003: Oilpan: Replace RefPtrs and raw pointers to Node and its subclasses in core/frame and core/page wit… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/ImageBitmapTest.cpp ('k') | Source/core/frame/SmartClip.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/SmartClip.h
diff --git a/Source/core/frame/SmartClip.h b/Source/core/frame/SmartClip.h
index b0e922051106616b6b49329dc9a1f4836211f39d..21955a2b3eac80532e34a64b3be78e4a4e23aa9e 100644
--- a/Source/core/frame/SmartClip.h
+++ b/Source/core/frame/SmartClip.h
@@ -39,11 +39,12 @@ namespace WebCore {
class SmartClipData {
public:
SmartClipData()
+ : m_isEmpty(true)
{
}
SmartClipData(Node* node, IntRect rect, String string)
- : m_node(node)
+ : m_isEmpty(!node)
, m_rect(rect)
, m_string(string)
{
@@ -52,7 +53,7 @@ public:
String toString();
private:
- RefPtr<Node> m_node;
+ bool m_isEmpty;
IntRect m_rect;
String m_string;
};
@@ -74,7 +75,7 @@ private:
Node* minNodeContainsNodes(Node* minNode, Node* newNode);
Node* findBestOverlappingNode(Node*, const IntRect& cropRect);
bool shouldSkipBackgroundImage(Node*);
- void collectOverlappingChildNodes(Node* parentNode, const IntRect& cropRect, Vector<Node*>& overlappingNodeInfoTable);
+ void collectOverlappingChildNodes(Node* parentNode, const IntRect& cropRect, WillBeHeapVector<RawPtrWillBeMember<Node> >& overlappingNodeInfoTable);
IntRect convertRectToWindow(const IntRect& nodeRect);
String extractTextFromNode(Node*);
« no previous file with comments | « Source/core/frame/ImageBitmapTest.cpp ('k') | Source/core/frame/SmartClip.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698