Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1244)

Issue 309463002: drive: Change DriveServiceInterface::GetChangeList's callback type to ChangeListCallback (Closed)

Created:
6 years, 6 months ago by hashimoto
Modified:
6 years, 6 months ago
Reviewers:
kinaba, tzik
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, tfarina, nhiroki, oshima+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Change DriveServiceInterface::GetChangeList's callback type to ChangeListCallback Move ConvertChangeListToResourceList() call to the callers' side. Replace ChangeList::set_items() with mutable_items() to efficiently handle data received from the server. BUG=231125 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273626

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -189 lines) Patch
M chrome/browser/chromeos/drive/job_scheduler.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.cc View 4 chunks +19 lines, -2 lines 0 comments Download
M chrome/browser/drive/drive_api_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/drive/drive_api_service.cc View 4 chunks +5 lines, -37 lines 0 comments Download
M chrome/browser/drive/drive_service_interface.h View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/drive/dummy_drive_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/drive/dummy_drive_service.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 16 chunks +54 lines, -35 lines 0 comments Download
M chrome/browser/drive/fake_drive_service_unittest.cc View 9 chunks +53 lines, -54 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_wrapper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_wrapper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/list_changes_task.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/list_changes_task.cc View 6 chunks +11 lines, -28 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/api_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/api_util.cc View 2 chunks +19 lines, -1 line 0 comments Download
M google_apis/drive/drive_api_parser.h View 3 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hashimoto
6 years, 6 months ago (2014-05-29 09:07:19 UTC) #1
kinaba
lgtm
6 years, 6 months ago (2014-05-29 09:28:18 UTC) #2
tzik
lgtm
6 years, 6 months ago (2014-05-29 13:45:32 UTC) #3
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 6 months ago (2014-05-29 15:46:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/309463002/60001
6 years, 6 months ago (2014-05-29 15:49:22 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 22:32:58 UTC) #6
Message was sent while issue was closed.
Change committed as 273626

Powered by Google App Engine
This is Rietveld 408576698