Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2193)

Unified Diff: chrome/browser/drive/drive_api_service.cc

Issue 309463002: drive: Change DriveServiceInterface::GetChangeList's callback type to ChangeListCallback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/drive/drive_api_service.h ('k') | chrome/browser/drive/drive_service_interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/drive/drive_api_service.cc
diff --git a/chrome/browser/drive/drive_api_service.cc b/chrome/browser/drive/drive_api_service.cc
index 017dc1af862fe5ba3b4716b16c87da2b7d3bf0e3..4df202de9a004cdc7e3eda87e2ffa020ac7bf4c5 100644
--- a/chrome/browser/drive/drive_api_service.cc
+++ b/chrome/browser/drive/drive_api_service.cc
@@ -31,6 +31,7 @@ using google_apis::AuthStatusCallback;
using google_apis::AuthorizeAppCallback;
using google_apis::CancelCallback;
using google_apis::ChangeList;
+using google_apis::ChangeListCallback;
using google_apis::DownloadActionCallback;
using google_apis::EntryActionCallback;
using google_apis::FileList;
@@ -185,35 +186,6 @@ void ConvertFileListToResourceListOnBlockingPoolAndRun(
base::Bind(&DidConvertToResourceListOnBlockingPool, callback));
}
-// Thin adapter of ConvertChangeListToResourceList.
-scoped_ptr<ResourceList> ConvertChangeListToResourceList(
- scoped_ptr<ChangeList> change_list) {
- return util::ConvertChangeListToResourceList(*change_list);
-}
-
-// Converts the FileList value to ResourceList on blocking pool and runs
-// |callback| on the UI thread.
-void ConvertChangeListToResourceListOnBlockingPoolAndRun(
- scoped_refptr<base::TaskRunner> blocking_task_runner,
- const GetResourceListCallback& callback,
- GDataErrorCode error,
- scoped_ptr<ChangeList> value) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- DCHECK(!callback.is_null());
-
- if (!value) {
- callback.Run(error, scoped_ptr<ResourceList>());
- return;
- }
-
- // Convert the value on blocking pool.
- base::PostTaskAndReplyWithResult(
- blocking_task_runner.get(),
- FROM_HERE,
- base::Bind(&ConvertChangeListToResourceList, base::Passed(&value)),
- base::Bind(&DidConvertToResourceListOnBlockingPool, callback));
-}
-
// Converts the FileResource value to ResourceEntry for upload range request,
// and runs |callback| on the UI thread.
void ConvertFileResourceToResourceEntryForUploadRangeAndRun(
@@ -435,14 +407,12 @@ CancelCallback DriveAPIService::SearchByTitle(
CancelCallback DriveAPIService::GetChangeList(
int64 start_changestamp,
- const GetResourceListCallback& callback) {
+ const ChangeListCallback& callback) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DCHECK(!callback.is_null());
ChangesListRequest* request = new ChangesListRequest(
- sender_.get(), url_generator_,
- base::Bind(&ConvertChangeListToResourceListOnBlockingPoolAndRun,
- blocking_task_runner_, callback));
+ sender_.get(), url_generator_, callback);
request->set_max_results(kMaxNumFilesResourcePerRequest);
request->set_start_change_id(start_changestamp);
request->set_fields(kChangeListFields);
@@ -451,15 +421,13 @@ CancelCallback DriveAPIService::GetChangeList(
CancelCallback DriveAPIService::GetRemainingChangeList(
const GURL& next_link,
- const GetResourceListCallback& callback) {
+ const ChangeListCallback& callback) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DCHECK(!next_link.is_empty());
DCHECK(!callback.is_null());
ChangesListNextPageRequest* request = new ChangesListNextPageRequest(
- sender_.get(),
- base::Bind(&ConvertChangeListToResourceListOnBlockingPoolAndRun,
- blocking_task_runner_, callback));
+ sender_.get(), callback);
request->set_next_link(next_link);
request->set_fields(kChangeListFields);
return sender_->StartRequestWithRetry(request);
« no previous file with comments | « chrome/browser/drive/drive_api_service.h ('k') | chrome/browser/drive/drive_service_interface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698