Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4577)

Unified Diff: chrome/browser/sync_file_system/drive_backend_v1/api_util.cc

Issue 309463002: drive: Change DriveServiceInterface::GetChangeList's callback type to ChangeListCallback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync_file_system/drive_backend_v1/api_util.h ('k') | google_apis/drive/drive_api_parser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync_file_system/drive_backend_v1/api_util.cc
diff --git a/chrome/browser/sync_file_system/drive_backend_v1/api_util.cc b/chrome/browser/sync_file_system/drive_backend_v1/api_util.cc
index 2ec97916a6e6f3e8c90b9a0086911247933e6734..62c579fea10cff34a81638eb366603a06396cefd 100644
--- a/chrome/browser/sync_file_system/drive_backend_v1/api_util.cc
+++ b/chrome/browser/sync_file_system/drive_backend_v1/api_util.cc
@@ -480,7 +480,7 @@ void APIUtil::ListChanges(int64 start_changestamp,
drive_service_->GetChangeList(
start_changestamp,
- base::Bind(&APIUtil::DidGetResourceList, AsWeakPtr(), callback));
+ base::Bind(&APIUtil::DidGetChangeList, AsWeakPtr(), callback));
}
void APIUtil::ContinueListing(const GURL& next_link,
@@ -675,6 +675,24 @@ void APIUtil::OnConnectionTypeChanged(
CancelAllUploads(google_apis::GDATA_NO_CONNECTION);
}
+void APIUtil::DidGetChangeList(
+ const ResourceListCallback& callback,
+ google_apis::GDataErrorCode error,
+ scoped_ptr<google_apis::ChangeList> change_list) {
+ DCHECK(CalledOnValidThread());
+
+ if (error != google_apis::HTTP_SUCCESS) {
+ DVLOG(2) << "Error on listing changes: " << error;
+ callback.Run(error, scoped_ptr<google_apis::ResourceList>());
+ return;
+ }
+
+ DVLOG(2) << "Got change list";
+ DCHECK(change_list);
+ callback.Run(error,
+ drive::util::ConvertChangeListToResourceList(*change_list));
+}
+
void APIUtil::DidGetResourceList(
const ResourceListCallback& callback,
google_apis::GDataErrorCode error,
« no previous file with comments | « chrome/browser/sync_file_system/drive_backend_v1/api_util.h ('k') | google_apis/drive/drive_api_parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698