Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 307933011: Fix test failures of IDBTransactionTest.EnsureLifetime with ENABLE(OILPAN) (Closed)

Created:
6 years, 6 months ago by haraken
Modified:
6 years, 6 months ago
CC:
blink-reviews, arv+blink, alecflett, ericu+idb_chromium.org, abarth-chromium, blink-reviews-bindings_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org
Visibility:
Public.

Description

Fix test failures of IDBTransactionTest.EnsureLifetime with ENABLE(OILPAN) This is a regression caused by r174937. After r174937, ExecutionContexts created for IDBRequestTest and IDBTransactionTest outlive the tests (because the lifetime of the ExecutionContexts is bound to a ScriptState associated with the tests). This is wrong, and we should clear the ExecutionContexts when shutting down the tests. BUG=379616 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175259

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M Source/bindings/v8/ScriptState.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/ScriptState.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBRequestTest.cpp View 2 chunks +8 lines, -1 line 0 comments Download
M Source/modules/indexeddb/IDBTransactionTest.cpp View 1 2 3 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
haraken
PTAL
6 years, 6 months ago (2014-06-02 04:55:32 UTC) #1
haraken
6 years, 6 months ago (2014-06-02 04:55:40 UTC) #2
tkent
lgtm. I think it's ok to use constructor/destructor instead of SetUp/TearDown in this case. https://code.google.com/p/googletest/wiki/FAQ#Should_I_use_the_constructor/destructor_of_the_test_fixture_or_t
6 years, 6 months ago (2014-06-02 06:08:14 UTC) #3
tkent
Please remove MAYBE_EnsureLifetime in IDBTransactionTest.cpp.
6 years, 6 months ago (2014-06-02 06:09:14 UTC) #4
zerny-chromium
lgtm
6 years, 6 months ago (2014-06-02 06:22:44 UTC) #5
sof
As other IDB unit tests are also failing w/ Oilpan atm, it'd be good to ...
6 years, 6 months ago (2014-06-02 06:40:53 UTC) #6
haraken
On 2014/06/02 06:09:14, tkent wrote: > Please remove MAYBE_EnsureLifetime in IDBTransactionTest.cpp. Removed. Landing the CL ...
6 years, 6 months ago (2014-06-02 07:07:28 UTC) #7
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 6 months ago (2014-06-02 07:07:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/307933011/40001
6 years, 6 months ago (2014-06-02 07:07:48 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 08:58:14 UTC) #10
Message was sent while issue was closed.
Change committed as 175259

Powered by Google App Engine
This is Rietveld 408576698