Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: Source/modules/indexeddb/IDBRequestTest.cpp

Issue 307933011: Fix test failures of IDBTransactionTest.EnsureLifetime with ENABLE(OILPAN) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/ScriptState.cpp ('k') | Source/modules/indexeddb/IDBTransactionTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/indexeddb/IDBRequestTest.cpp
diff --git a/Source/modules/indexeddb/IDBRequestTest.cpp b/Source/modules/indexeddb/IDBRequestTest.cpp
index 2ddbf31440b5f2e9018c144942a76a75ce6eaed6..de4c20cb89a7909225a92052fbe5f7f27fbbd8de 100644
--- a/Source/modules/indexeddb/IDBRequestTest.cpp
+++ b/Source/modules/indexeddb/IDBRequestTest.cpp
@@ -75,8 +75,14 @@ class IDBRequestTest : public testing::Test {
public:
IDBRequestTest()
: m_scope(v8::Isolate::GetCurrent())
+ , m_executionContext(adoptRef(new NullExecutionContext()))
{
- m_scope.scriptState()->setExecutionContext(adoptRef(new NullExecutionContext()));
+ m_scope.scriptState()->setExecutionContext(m_executionContext.get());
+ }
+
+ ~IDBRequestTest()
+ {
+ m_scope.scriptState()->setExecutionContext(0);
}
v8::Isolate* isolate() const { return m_scope.isolate(); }
@@ -85,6 +91,7 @@ public:
private:
V8TestingScope m_scope;
+ RefPtr<ExecutionContext> m_executionContext;
};
TEST_F(IDBRequestTest, EventsAfterStopping)
« no previous file with comments | « Source/bindings/v8/ScriptState.cpp ('k') | Source/modules/indexeddb/IDBTransactionTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698