content/common/child_process_host_impl.cc - Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/child_process_host_impl.cc

Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing windows build, landing again. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/child_process_host_impl.cc

diff --git a/content/common/child_process_host_impl.cc b/content/common/child_process_host_impl.cc

index 9ae7c82d6724260f76620f2454127313e77518de..1dccab0838504ffffcf51186cfaf5d23b451b06d 100644

--- a/content/common/child_process_host_impl.cc

+++ b/content/common/child_process_host_impl.cc

@@ -164,8 +164,7 @@ void ChildProcessHostImpl::ForceShutdown() {

std::string ChildProcessHostImpl::CreateChannel() {

channel_id_ = IPC::Channel::GenerateVerifiedChannelID(std::string());

- channel_.reset(new IPC::Channel(

- channel_id_, IPC::Channel::MODE_SERVER, this));

+ channel_ = IPC::Channel::CreateServer(channel_id_, this);

if (!channel_->Connect())

return std::string();