content/browser/plugin_service_impl_browsertest.cc - Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/plugin_service_impl_browsertest.cc

Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing windows build, landing again. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/plugin_service_impl_browsertest.cc

diff --git a/content/browser/plugin_service_impl_browsertest.cc b/content/browser/plugin_service_impl_browsertest.cc

index 44f47547289725a380cee4bf5141fab66acb3d45..7a3271e6c78f92f57a832e59e93e2650fb7a3673 100644

--- a/content/browser/plugin_service_impl_browsertest.cc

+++ b/content/browser/plugin_service_impl_browsertest.cc

@@ -60,7 +60,7 @@ class MockPluginProcessHostClient : public PluginProcessHost::Client,

ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO));

ASSERT_TRUE(set_plugin_info_called_);

ASSERT_TRUE(!channel_);

- channel_ = new IPC::Channel(handle, IPC::Channel::MODE_CLIENT, this);

+ channel_ = IPC::Channel::CreateClient(handle, this).release();

ASSERT_TRUE(channel_->Connect());

}