content/renderer/render_thread_impl_browsertest.cc - Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_thread_impl_browsertest.cc

Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing windows build, landing again. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_thread_impl_browsertest.cc

diff --git a/content/renderer/render_thread_impl_browsertest.cc b/content/renderer/render_thread_impl_browsertest.cc

index 6715ef333748a81860725309949c6694b2c6daae..11d486ee2cef39f1e690c1ff2a4bbfe1f037e096 100644

--- a/content/renderer/render_thread_impl_browsertest.cc

+++ b/content/renderer/render_thread_impl_browsertest.cc

@@ -57,8 +57,9 @@ TEST_F(RenderThreadImplBrowserTest,

std::string channel_id = IPC::Channel::GenerateVerifiedChannelID(

std::string());

DummyListener dummy_listener;

- IPC::Channel channel(channel_id, IPC::Channel::MODE_SERVER, &dummy_listener);

- ASSERT_TRUE(channel.Connect());

+ scoped_ptr<IPC::Channel> channel(

+ IPC::Channel::CreateServer(channel_id, &dummy_listener));

+ ASSERT_TRUE(channel->Connect());

scoped_ptr<MockRenderProcess> mock_process(new MockRenderProcess);

// Owned by mock_process.

« no previous file with comments | « content/common/child_process_host_impl.cc ('k') | ipc/BUILD.gn » ('j') | no next file with comments »