content/browser/plugin_data_remover_impl.cc - Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/plugin_data_remover_impl.cc

Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing windows build, landing again. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/plugin_data_remover_impl.cc

diff --git a/content/browser/plugin_data_remover_impl.cc b/content/browser/plugin_data_remover_impl.cc

index 9133e59ec91388696ac61c2a6657a8c3f7f186c4..a318e724d4bd6d4331b419bca5ed6abc99602dd5 100644

--- a/content/browser/plugin_data_remover_impl.cc

+++ b/content/browser/plugin_data_remover_impl.cc

@@ -226,7 +226,7 @@ class PluginDataRemoverImpl::Context

return;

DCHECK(!channel_.get());

- channel_.reset(new IPC::Channel(handle, IPC::Channel::MODE_CLIENT, this));

+ channel_ = IPC::Channel::CreateClient(handle, this);

if (!channel_->Connect()) {

NOTREACHED() << "Couldn't connect to plugin";

SignalDone();