components/nacl/loader/nacl_ipc_adapter.cc - Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/nacl_ipc_adapter.cc

Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing windows build, landing again. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/loader/nacl_ipc_adapter.cc

diff --git a/components/nacl/loader/nacl_ipc_adapter.cc b/components/nacl/loader/nacl_ipc_adapter.cc

index 1398b222325f24fbf38e9ea51bd556848c15d682..d3160e4e51e09b7fd27baa4a3d1c47f041e60a5b 100644

--- a/components/nacl/loader/nacl_ipc_adapter.cc

+++ b/components/nacl/loader/nacl_ipc_adapter.cc

@@ -329,8 +329,7 @@ NaClIPCAdapter::NaClIPCAdapter(const IPC::ChannelHandle& handle,

cond_var_(&lock_),

task_runner_(runner),

locked_data_() {

- io_thread_data_.channel_.reset(

- new IPC::Channel(handle, IPC::Channel::MODE_SERVER, this));

+ io_thread_data_.channel_ = IPC::Channel::CreateServer(handle, this);

// Note, we can not PostTask for ConnectChannelOnIOThread here. If we did,

// and that task ran before this constructor completes, the reference count

// would go to 1 and then to 0 because of the Task, before we've been returned