components/nacl/broker/nacl_broker_listener.cc - Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/broker/nacl_broker_listener.cc

Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing windows build, landing again. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/broker/nacl_broker_listener.cc

diff --git a/components/nacl/broker/nacl_broker_listener.cc b/components/nacl/broker/nacl_broker_listener.cc

index c4f268da3cddb3ab83159970df2c3d9cd9ef1e12..bceed222795711864a31cbd8e9ca39216687c0ea 100644

--- a/components/nacl/broker/nacl_broker_listener.cc

+++ b/components/nacl/broker/nacl_broker_listener.cc

@@ -40,8 +40,7 @@ void NaClBrokerListener::Listen() {

std::string channel_name =

CommandLine::ForCurrentProcess()->GetSwitchValueASCII(

switches::kProcessChannelID);

- channel_.reset(new IPC::Channel(

- channel_name, IPC::Channel::MODE_CLIENT, this));

+ channel_ = IPC::Channel::CreateClient(channel_name, this);

CHECK(channel_->Connect());

base::MessageLoop::current()->Run();

}