cloud_print/service/win/setup_listener.cc - Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/service/win/setup_listener.cc

Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing windows build, landing again. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cloud_print/service/win/setup_listener.cc

diff --git a/cloud_print/service/win/setup_listener.cc b/cloud_print/service/win/setup_listener.cc

index dd1cb375d2127cb37051b3fcf2f86150f0628a7a..c0b6d1b9b3e5e814b254fe38e2448757b652ad87 100644

--- a/cloud_print/service/win/setup_listener.cc

+++ b/cloud_print/service/win/setup_listener.cc

@@ -117,8 +117,8 @@ void SetupListener::Connect(const base::string16& user) {

IPC::Channel::kReadBufferSize,

IPC::Channel::kReadBufferSize, 5000, &attribs));

if (pipe.IsValid()) {

- channel_.reset(new IPC::Channel(IPC::ChannelHandle(pipe),

- IPC::Channel::MODE_SERVER, this));

+ channel_ = IPC::Channel::CreateServer(IPC::ChannelHandle(pipe),

+ this);

channel_->Connect();

}