cloud_print/service/win/service_listener.cc - Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/service/win/service_listener.cc

Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing windows build, landing again. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cloud_print/service/win/service_listener.cc

diff --git a/cloud_print/service/win/service_listener.cc b/cloud_print/service/win/service_listener.cc

index 53622a8b2bed116b1fef382863130ade268467e6..bdb221743bb4688cc2a47115b4c1f93863ed192b 100644

--- a/cloud_print/service/win/service_listener.cc

+++ b/cloud_print/service/win/service_listener.cc

@@ -91,8 +91,8 @@ void ServiceListener::Connect() {

SECURITY_SQOS_PRESENT | SECURITY_IDENTIFICATION |

FILE_FLAG_OVERLAPPED, NULL));

if (handle.IsValid()) {

- channel_.reset(new IPC::Channel(IPC::ChannelHandle(handle),

- IPC::Channel::MODE_CLIENT, this));

+ channel_ = IPC::Channel::CreateClient(IPC::ChannelHandle(handle),

+ this);

channel_->Connect();

} else {

ipc_thread_->message_loop()->PostDelayedTask(