Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4375)

Unified Diff: chrome/utility/importer/firefox_importer_unittest_utils_mac.cc

Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing windows build, landing again. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/pepper_flash_settings_manager.cc ('k') | cloud_print/service/win/service_listener.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
diff --git a/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc b/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
index 5c385ded5e80e849d962f797e6f5072acbd16cce..9608f63c76161ffaf40e4d12b0302b6f858f2b26 100644
--- a/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
+++ b/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
@@ -130,9 +130,7 @@ bool FFUnitTestDecryptorProxy::Setup(const base::FilePath& nss_path) {
message_loop_.reset(new base::MessageLoopForIO());
listener_.reset(new FFDecryptorServerChannelListener());
- channel_.reset(new IPC::Channel(kTestChannelID,
- IPC::Channel::MODE_SERVER,
- listener_.get()));
+ channel_ = IPC::Channel::CreateServer(kTestChannelID, listener_.get());
CHECK(channel_->Connect());
listener_->SetSender(channel_.get());
@@ -264,9 +262,10 @@ MULTIPROCESS_IPC_TEST_MAIN(NSSDecrypterChildProcess) {
base::MessageLoopForIO main_message_loop;
FFDecryptorClientChannelListener listener;
- IPC::Channel channel(kTestChannelID, IPC::Channel::MODE_CLIENT, &listener);
- CHECK(channel.Connect());
- listener.SetSender(&channel);
+ scoped_ptr<IPC::Channel> channel = IPC::Channel::CreateClient(
+ kTestChannelID, &listener);
+ CHECK(channel->Connect());
+ listener.SetSender(channel.get());
// run message loop
base::MessageLoop::current()->Run();
« no previous file with comments | « chrome/browser/pepper_flash_settings_manager.cc ('k') | cloud_print/service/win/service_listener.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698