chrome/browser/pepper_flash_settings_manager.cc - Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/pepper_flash_settings_manager.cc

Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing windows build, landing again. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/pepper_flash_settings_manager.cc

diff --git a/chrome/browser/pepper_flash_settings_manager.cc b/chrome/browser/pepper_flash_settings_manager.cc

index 1945d67c909e9dc38ad985615d5500869f6fe7d5..7a3230f727d87602c1a2fb979e1ddcf7692fe784 100644

--- a/chrome/browser/pepper_flash_settings_manager.cc

+++ b/chrome/browser/pepper_flash_settings_manager.cc

@@ -353,7 +353,7 @@ void PepperFlashSettingsManager::Core::ConnectToChannel(

return;

}

- channel_.reset(new IPC::Channel(handle, IPC::Channel::MODE_CLIENT, this));

+ channel_ = IPC::Channel::CreateClient(handle, this);

if (!channel_->Connect()) {

DLOG(ERROR) << "Couldn't connect to plugin";

NotifyErrorFromIOThread();

« no previous file with comments | « no previous file | chrome/utility/importer/firefox_importer_unittest_utils_mac.cc » ('j') | no next file with comments »