Make sure we never pass a null Frame to Document::canNavigate()

Make sure we never pass a null Frame to Document::canNavigate()

Make sure we never pass a null Frame to Document::canNavigate() and update it
to take the Frame by reference to const. It makes little sense to pass null to
a canNavigate() function, especially considering the implementation was
returning true in this case (there was a FIXME about it).

R=adamk@chromium.org, eseidel@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175295

[eseidel, 2014-06-02 05:19:28]

https://codereview.chromium.org/307223002/diff/1/Source/core/loader/FrameLoad...
File Source/core/loader/FrameLoader.cpp (right):

https://codereview.chromium.org/307223002/diff/1/Source/core/loader/FrameLoad...
Source/core/loader/FrameLoader.cpp:1389: if (!frame ||
!activeDocument->canNavigate(*frame))
So this is the magic to fix the layout test?

[eseidel, 2014-06-02 05:20:27]

https://codereview.chromium.org/307223002/diff/1/Source/core/frame/Frame.h
File Source/core/frame/Frame.h (right):

https://codereview.chromium.org/307223002/diff/1/Source/core/frame/Frame.h#ne...
Source/core/frame/Frame.h:145: // Allow equality comparisons of Frames by
reference or pointer, interchangeably.
Can we make this a macro?  Seems silly to have to type this out.

[Inactive, 2014-06-02 12:16:37]

https://codereview.chromium.org/307223002/diff/1/Source/core/frame/Frame.h
File Source/core/frame/Frame.h (right):

https://codereview.chromium.org/307223002/diff/1/Source/core/frame/Frame.h#ne...
Source/core/frame/Frame.h:145: // Allow equality comparisons of Frames by
reference or pointer, interchangeably.
On 2014/06/02 05:20:27, eseidel wrote:
> Can we make this a macro?  Seems silly to have to type this out.

Makes sense. We already duplicate this for several classes. Will do (likely in a
separate patch for clarity).

https://codereview.chromium.org/307223002/diff/1/Source/core/loader/FrameLoad...
File Source/core/loader/FrameLoader.cpp (right):

https://codereview.chromium.org/307223002/diff/1/Source/core/loader/FrameLoad...
Source/core/loader/FrameLoader.cpp:1389: if (!frame ||
!activeDocument->canNavigate(*frame))
On 2014/06/02 05:19:29, eseidel wrote:
> So this is the magic to fix the layout test?

No, I did not do anything to fix the layout test. I think the comment was
outdated. In this part of the code, the function was returning 0 already if
frame was null:
- The if check would frame so it would do "return frame", frame being null.

Now, the if check succeeds, so it explicitly returns 0.

[eseidel, 2014-06-02 16:39:13]

lgtm

[Inactive, 2014-06-02 16:43:29]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-06-02 16:43:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/307223002/1

[commit-bot: I haz the power, 2014-06-02 16:44:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6692)

[commit-bot: I haz the power, 2014-06-02 16:59:39]

Change committed as 175295