Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: Source/core/dom/Document.h

Issue 307223002: Make sure we never pass a null Frame to Document::canNavigate() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/dom/Document.cpp » ('j') | Source/core/frame/Frame.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
9 * Copyright (C) 2011 Google Inc. All rights reserved. 9 * Copyright (C) 2011 Google Inc. All rights reserved.
10 * 10 *
(...skipping 561 matching lines...) Expand 10 before | Expand all | Expand 10 after
572 const KURL& baseElementURL() const { return m_baseElementURL; } 572 const KURL& baseElementURL() const { return m_baseElementURL; }
573 const AtomicString& baseTarget() const { return m_baseTarget; } 573 const AtomicString& baseTarget() const { return m_baseTarget; }
574 void processBaseElement(); 574 void processBaseElement();
575 575
576 KURL completeURL(const String&) const; 576 KURL completeURL(const String&) const;
577 KURL completeURLWithOverride(const String&, const KURL& baseURLOverride) con st; 577 KURL completeURLWithOverride(const String&, const KURL& baseURLOverride) con st;
578 578
579 virtual String userAgent(const KURL&) const OVERRIDE FINAL; 579 virtual String userAgent(const KURL&) const OVERRIDE FINAL;
580 virtual void disableEval(const String& errorMessage) OVERRIDE FINAL; 580 virtual void disableEval(const String& errorMessage) OVERRIDE FINAL;
581 581
582 bool canNavigate(Frame* targetFrame); 582 bool canNavigate(const Frame& targetFrame);
583 LocalFrame* findUnsafeParentScrollPropagationBoundary(); 583 LocalFrame* findUnsafeParentScrollPropagationBoundary();
584 584
585 CSSStyleSheet& elementSheet(); 585 CSSStyleSheet& elementSheet();
586 586
587 virtual PassRefPtrWillBeRawPtr<DocumentParser> createParser(); 587 virtual PassRefPtrWillBeRawPtr<DocumentParser> createParser();
588 DocumentParser* parser() const { return m_parser.get(); } 588 DocumentParser* parser() const { return m_parser.get(); }
589 ScriptableDocumentParser* scriptableDocumentParser() const; 589 ScriptableDocumentParser* scriptableDocumentParser() const;
590 590
591 bool printing() const { return m_printing; } 591 bool printing() const { return m_printing; }
592 void setPrinting(bool p) { m_printing = p; } 592 void setPrinting(bool p) { m_printing = p; }
(...skipping 851 matching lines...) Expand 10 before | Expand all | Expand 10 after
1444 inline bool Node::isDocumentNode() const 1444 inline bool Node::isDocumentNode() const
1445 { 1445 {
1446 return this == document(); 1446 return this == document();
1447 } 1447 }
1448 1448
1449 Node* eventTargetNodeForDocument(Document*); 1449 Node* eventTargetNodeForDocument(Document*);
1450 1450
1451 } // namespace WebCore 1451 } // namespace WebCore
1452 1452
1453 #endif // Document_h 1453 #endif // Document_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/Document.cpp » ('j') | Source/core/frame/Frame.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698