Source/core/dom/Document.h - Issue 307223002: Make sure we never pass a null Frame to Document::canNavigate()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.h

Issue 307223002: Make sure we never pass a null Frame to Document::canNavigate() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Document.h

diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h

index ac92aa97f5740338086d56515918beded2ee7efd..29d65624f1a5506315af4609d2da4025d336c835 100644

--- a/Source/core/dom/Document.h

+++ b/Source/core/dom/Document.h

@@ -579,7 +579,7 @@ public:

virtual String userAgent(const KURL&) const OVERRIDE FINAL;

virtual void disableEval(const String& errorMessage) OVERRIDE FINAL;

- bool canNavigate(Frame* targetFrame);

+ bool canNavigate(const Frame& targetFrame);

LocalFrame* findUnsafeParentScrollPropagationBoundary();

CSSStyleSheet& elementSheet();

« no previous file with comments | « no previous file | Source/core/dom/Document.cpp » ('j') | Source/core/frame/Frame.h » ('J')