Issue 307008: Explain what '&&' is for in IDS_IMPORT_SETTINGS: '&&' should ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 307008: Explain what '&&' is for in IDS_IMPORT_SETTINGS: '&&' should ... (Closed)

Created:
11 years, 2 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com, Mark Larson, laforge

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Explain what '&&' is for in IDS_IMPORT_SETTINGS: '&&' should be replaced with 'and' in the target language unless it's good to use '&' to mean 'and' in the language. BUG=24705 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29589

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/app/generated_resources.grd	View	1 2	2 chunks	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

With the description changed, these strings will be regarded as new strings and will be ...

11 years, 2 months ago (2009-10-20 20:41:29 UTC) #1

tony

11 years, 2 months ago (2009-10-20 20:45:20 UTC) #2

LGTM

http://codereview.chromium.org/307008/diff/2001/6
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/307008/diff/2001/6#newcode928
Line 928: <message name="IDS_IMPORT_SETTINGS" desc="The text label for the
Import menu item. Two consecutive ampersands between 'bookmarks' and 'settings'
represent a single ampersand after it's processed  and mean 'and' in English.
Therefore, it should be translated as such unless it's better to use an
ampersand to mean 'and' in the language.">
Nit: There appear to be two spaces between 'processed' and 'and'.