Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 306893003: Fix channel check for fatal error suppression. (Closed)

Created:
6 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Fix channel check for fatal error suppression. Fatal extensions errors should be suppressed on stable and beta channels of Chrome. This fixes a regression where they were instead suppressed on other channels. BUG=378374 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273997

Patch Set 1 #

Patch Set 2 : tyyyypo #

Patch Set 3 : fix failing checks #

Patch Set 4 : Remove CHECK in IsAvailable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M chrome/common/extensions/chrome_extensions_client.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/last_error.js View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/extension_api.cc View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
Ken Rockot(use gerrit already)
Fixing this cuz I'm a dum-dum
6 years, 6 months ago (2014-05-29 22:04:00 UTC) #1
not at google - send to devlin
doh. lgtm. pls merge :)
6 years, 6 months ago (2014-05-29 22:09:02 UTC) #2
Ken Rockot(use gerrit already)
On 2014/05/29 22:09:02, kalman wrote: > doh. lgtm. pls merge :) will do
6 years, 6 months ago (2014-05-29 22:09:51 UTC) #3
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 6 months ago (2014-05-29 22:09:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/306893003/20001
6 years, 6 months ago (2014-05-29 22:13:21 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 02:24:23 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 04:00:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/36463)
6 years, 6 months ago (2014-05-30 04:00:38 UTC) #8
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 6 months ago (2014-05-30 05:33:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/306893003/20001
6 years, 6 months ago (2014-05-30 05:34:31 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 09:30:48 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 10:55:21 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/36648)
6 years, 6 months ago (2014-05-30 10:55:21 UTC) #13
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 6 months ago (2014-05-30 22:26:37 UTC) #14
Ken Rockot(use gerrit already)
The CQ bit was unchecked by rockot@chromium.org
6 years, 6 months ago (2014-05-30 22:29:26 UTC) #15
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 6 months ago (2014-05-30 22:35:25 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/306893003/60001
6 years, 6 months ago (2014-05-30 22:39:06 UTC) #17
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 03:45:53 UTC) #18
Message was sent while issue was closed.
Change committed as 273997

Powered by Google App Engine
This is Rietveld 408576698