Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2223)

Unified Diff: chrome/common/extensions/chrome_extensions_client.cc

Issue 306893003: Fix channel check for fatal error suppression. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove CHECK in IsAvailable Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/last_error.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/chrome_extensions_client.cc
diff --git a/chrome/common/extensions/chrome_extensions_client.cc b/chrome/common/extensions/chrome_extensions_client.cc
index cd58fb8053527a1db2bb729bf0219e5ca13e2acf..5bea768e5393eab8c35beed514dc245bf0e0e984 100644
--- a/chrome/common/extensions/chrome_extensions_client.cc
+++ b/chrome/common/extensions/chrome_extensions_client.cc
@@ -272,8 +272,8 @@ void ChromeExtensionsClient::RegisterAPISchemaResources(
}
bool ChromeExtensionsClient::ShouldSuppressFatalErrors() const {
- // <= dev means dev, canary, and trunk.
- return GetCurrentChannel() <= chrome::VersionInfo::CHANNEL_DEV;
+ // Suppress fatal errors only on beta and stable channels.
+ return GetCurrentChannel() > chrome::VersionInfo::CHANNEL_DEV;
}
// static
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/last_error.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698