chrome/renderer/resources/extensions/last_error.js - Issue 306893003: Fix channel check for fatal error suppression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/last_error.js

Issue 306893003: Fix channel check for fatal error suppression. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove CHECK in IsAvailable Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/resources/extensions/last_error.js

diff --git a/chrome/renderer/resources/extensions/last_error.js b/chrome/renderer/resources/extensions/last_error.js

index 2cf394755cc3d23010c9babaf9976fad2665be51..b096aa4e366d6d371a92fbc0ed5a6acd6d2f3dbc 100644

--- a/chrome/renderer/resources/extensions/last_error.js

+++ b/chrome/renderer/resources/extensions/last_error.js

@@ -28,7 +28,7 @@ function set(name, message, stack, targetChrome) {

clear(targetChrome); // in case somebody has set a sneaky getter/setter

var errorObject = { message: message };

- if (targetChrome && targetChrome.extension)

+ if (GetAvailability('extension.lastError').is_available)

targetChrome.extension.lastError = errorObject;

assertRuntimeIsAvailable();

@@ -81,7 +81,7 @@ function clear(targetChrome) {

if (!targetChrome)

throw new Error('No target chrome to clear error');

- if (targetChrome && targetChrome.extension)

+ if (GetAvailability('extension.lastError').is_available)

delete targetChrome.extension.lastError;

assertRuntimeIsAvailable();