Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: Source/bindings/v8/custom/V8DedicatedWorkerGlobalScopeCustom.cpp

Issue 30673002: More informative error messages for non-Transferables. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8DedicatedWorkerGlobalScopeCustom.cpp
diff --git a/Source/bindings/v8/custom/V8DedicatedWorkerGlobalScopeCustom.cpp b/Source/bindings/v8/custom/V8DedicatedWorkerGlobalScopeCustom.cpp
index ffa25a147a0b9f0e3bbc5aef81f5d19e157e8cbb..4743935860fef9b4ba7d5be6feb2a2e201876381 100644
--- a/Source/bindings/v8/custom/V8DedicatedWorkerGlobalScopeCustom.cpp
+++ b/Source/bindings/v8/custom/V8DedicatedWorkerGlobalScopeCustom.cpp
@@ -46,7 +46,8 @@ void V8DedicatedWorkerGlobalScope::postMessageMethodCustom(const v8::FunctionCal
MessagePortArray ports;
ArrayBufferArray arrayBuffers;
if (args.Length() > 1) {
- if (!extractTransferables(args[1], ports, arrayBuffers, args.GetIsolate()))
+ if (!extractTransferables(args[1], ports, arrayBuffers,
+ args.GetIsolate(), "Second argument is not a sequence type"))
Mike West 2013/10/21 06:51:22 Two things: 1. Can you bring in ExceptionMessages
return;
}
bool didThrow = false;

Powered by Google App Engine
This is Rietveld 408576698