More informative error messages for non-Transferables.

Source/bindings/v8/custom/V8DedicatedWorkerGlobalScopeCustom.cpp

 /*
  * Copyright (C) 2009, 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 28 matching lines @@
 #include "wtf/ArrayBuffer.h"
 
 namespace WebCore {
 
 void V8DedicatedWorkerGlobalScope::postMessageMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)
 {
     DedicatedWorkerGlobalScope* workerGlobalScope = V8DedicatedWorkerGlobalScope::toNative(args.Holder());
     MessagePortArray ports;
     ArrayBufferArray arrayBuffers;
     if (args.Length() > 1) {
-        if (!extractTransferables(args[1], ports, arrayBuffers, args.GetIsolate()))
+        if (!extractTransferables(args[1], ports, arrayBuffers,
+            args.GetIsolate(), "Second argument is not a sequence type"))

[Mike West, 2013/10/21 06:51:22]

Two things:

1. Can you bring in ExceptionMessages here? Something like
"ExceptionMessages::failedToExecute("postMessage", "WorkerGlobalScope", ...)"
would generate a friendlier error message.

2. I'd prefer to use something more clear than "sequence type". Developers don't
read IDL (and, honestly, I had to go find the IDL spec to understand what this
meant. :) ). I'd suggest something like "The second argument ('transfer') is
neither an array, nor does it support indexed properties."

             return;
     }
     bool didThrow = false;
     RefPtr<SerializedScriptValue> message =
         SerializedScriptValue::create(args[0],
                                       &ports,
                                       &arrayBuffers,
                                       didThrow,
                                       args.GetIsolate());
     if (didThrow)
         return;
     ExceptionState es(args.GetIsolate());
     workerGlobalScope->postMessage(message.release(), &ports, es);
     es.throwIfNeeded();
 }
 
 } // namespace WebCore