Source/bindings/v8/custom/V8MessagePortCustom.cpp - Issue 30673002: More informative error messages for non-Transferables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8MessagePortCustom.cpp

Issue 30673002: More informative error messages for non-Transferables. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/v8/custom/V8DedicatedWorkerGlobalScopeCustom.cpp ('K') | « Source/bindings/v8/custom/V8DedicatedWorkerGlobalScopeCustom.cpp ('k') | Source/bindings/v8/custom/V8WindowCustom.cpp » ('j') | Source/bindings/v8/custom/V8WindowCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8MessagePortCustom.cpp

diff --git a/Source/bindings/v8/custom/V8MessagePortCustom.cpp b/Source/bindings/v8/custom/V8MessagePortCustom.cpp

index cedf23f3274ff44d92382051c786a3a1ce722334..de53c91fb68ea22bf9bb737b205aac368874826d 100644

--- a/Source/bindings/v8/custom/V8MessagePortCustom.cpp

+++ b/Source/bindings/v8/custom/V8MessagePortCustom.cpp

@@ -46,7 +46,8 @@ void V8MessagePort::postMessageMethodCustom(const v8::FunctionCallbackInfo<v8::V

MessagePortArray portArray;

ArrayBufferArray arrayBufferArray;

if (args.Length() > 1) {

- if (!extractTransferables(args[1], portArray, arrayBufferArray, args.GetIsolate()))

+ if (!extractTransferables(args[1], portArray, arrayBufferArray,

+ args.GetIsolate(), "Second argument is not a sequence type"))

Mike West 2013/10/21 06:51:22 Same comments here as V8DedicatedWorkerGlobalScope

return;

}

bool didThrow = false;