Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 306663003: Move all code generation from GrGLProgram to GrGLShaderBuilder (Closed)

Created:
6 years, 6 months ago by bsalomon
Modified:
6 years, 6 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Move all code generation from GrGLProgram to GrGLShaderBuilder Committed: http://code.google.com/p/skia/source/detail?r=14974

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : line wraps #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -114 lines) Patch
M src/gpu/gl/GrGLProgram.h View 2 chunks +1 line, -18 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 2 2 chunks +12 lines, -86 lines 2 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 1 5 chunks +44 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 1 2 7 chunks +106 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
Both classes could use some refactoring in their code flow, but I wanted to keep ...
6 years, 6 months ago (2014-05-28 19:43:14 UTC) #1
robertphillips
lgtm https://codereview.chromium.org/306663003/diff/40001/src/gpu/gl/GrGLProgram.cpp File src/gpu/gl/GrGLProgram.cpp (right): https://codereview.chromium.org/306663003/diff/40001/src/gpu/gl/GrGLProgram.cpp#newcode49 src/gpu/gl/GrGLProgram.cpp:49: Does it make sense to have a GenProgramOutput ...
6 years, 6 months ago (2014-05-28 20:08:45 UTC) #2
bsalomon
https://codereview.chromium.org/306663003/diff/40001/src/gpu/gl/GrGLProgram.cpp File src/gpu/gl/GrGLProgram.cpp (right): https://codereview.chromium.org/306663003/diff/40001/src/gpu/gl/GrGLProgram.cpp#newcode49 src/gpu/gl/GrGLProgram.cpp:49: On 2014/05/28 20:08:46, robertphillips wrote: > Does it make ...
6 years, 6 months ago (2014-05-28 20:09:50 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 6 months ago (2014-05-29 18:59:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/306663003/40001
6 years, 6 months ago (2014-05-29 19:00:05 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 19:10:04 UTC) #6
Message was sent while issue was closed.
Change committed as 14974

Powered by Google App Engine
This is Rietveld 408576698