Move all code generation from GrGLProgram to GrGLShaderBuilder

src/gpu/gl/GrGLProgram.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "GrGLProgram.h"
 
 #include "GrAllocator.h"
@@ skipping 28 matching lines @@
 : fGpu(gpu)
 , fUniformManager(gpu)
 , fHasVertexShader(false)
 , fNumTexCoordSets(0) {
     fDesc = desc;
     fProgramID = 0;
 
     fDstCopyTexUnit = -1;
 
     fColor = GrColor_ILLEGAL;
 

[robertphillips, 2014/05/28 20:08:46]

Does it make sense to have a GenProgramOutput in the GrGLProgram object?

[bsalomon, 2014/05/28 20:09:50]

Maybe... I'm working on the next cleanup CL now.

-    if (fDesc.getHeader().fHasVertexCode ||
-        !fGpu->shouldUseFixedFunctionTexturing()) {
-        GrGLFullShaderBuilder fullBuilder(fGpu, fUniformManager, fDesc);
-        if (this->genProgram(&fullBuilder, colorStages, coverageStages)) {
-            fUniformHandles.fViewMatrixUni = fullBuilder.getViewMatrixUniform();
-            fUniformHandles.fRTAdjustmentUni = fullBuilder.getRTAdjustmentVecUniform();
-            fHasVertexShader = true;
-        }
-    } else {
-        GrGLFragmentOnlyShaderBuilder fragmentOnlyBuilder(fGpu, fUniformManager, fDesc);
-        if (this->genProgram(&fragmentOnlyBuilder, colorStages, coverageStages)) {
-            fNumTexCoordSets = fragmentOnlyBuilder.getNumTexCoordSets();
-        }
+    GrGLShaderBuilder::GenProgramOutput output;
+
+    if (GrGLShaderBuilder::GenProgram(gpu, fUniformManager, desc, colorStages, coverageStages,
+                                      &output)) {
+        fProgramID = output.fProgramID;
+        fUniformHandles = output.fUniformHandles;
+        fColorEffects.reset(output.fColorEffects);
+        fCoverageEffects.reset(output.fCoverageEffects);
+        fHasVertexShader = output.fHasVS;
+        fNumTexCoordSets = output.fNumTexCoordSets;
+        fGpu = gpu;
+        this->initSamplerUniforms();
     }
 }
 
 GrGLProgram::~GrGLProgram() {
     if (fProgramID) {
         GL_CALL(DeleteProgram(fProgramID));
     }
 }
 
 void GrGLProgram::abandon() {
@@ skipping 15 matching lines @@
         case GrGLProgramDesc::kCombineWithDst_CoverageOutput:
             // We should only have set this if the blend was specified as (1, 0)
             SkASSERT(kOne_GrBlendCoeff == *srcCoeff && kZero_GrBlendCoeff == *dstCoeff);
             break;
         default:
             SkFAIL("Unexpected coverage output");
             break;
     }
 }
 
-bool GrGLProgram::genProgram(GrGLShaderBuilder* builder,
-                             const GrEffectStage* colorStages[],
-                             const GrEffectStage* coverageStages[]) {
-    SkASSERT(0 == fProgramID);
-
-    const GrGLProgramDesc::KeyHeader& header = fDesc.getHeader();
-
-    // incoming color to current stage being processed.
-    GrGLSLExpr4 inColor = builder->getInputColor();
-
-    fColorEffects.reset(
-        builder->createAndEmitEffects(colorStages,
-                                      fDesc.effectKeys(),
-                                      fDesc.numColorEffects(),
-                                      &inColor));
-
-    ///////////////////////////////////////////////////////////////////////////
-    // compute the partial coverage
-    GrGLSLExpr4 inCoverage = builder->getInputCoverage();
-
-    fCoverageEffects.reset(
-        builder->createAndEmitEffects(coverageStages,
-                                      fDesc.getEffectKeys() + fDesc.numColorEffects(),
-                                      fDesc.numCoverageEffects(),
-                                      &inCoverage));
-
-    if (GrGLProgramDesc::CoverageOutputUsesSecondaryOutput(header.fCoverageOutput)) {
-        const char* secondaryOutputName = builder->enableSecondaryOutput();
-
-        // default coeff to ones for kCoverage_DualSrcOutput
-        GrGLSLExpr4 coeff(1);
-        if (GrGLProgramDesc::kSecondaryCoverageISA_CoverageOutput == header.fCoverageOutput) {
-            // Get (1-A) into coeff
-            coeff = GrGLSLExpr4::VectorCast(GrGLSLExpr1(1) - inColor.a());
-        } else if (GrGLProgramDesc::kSecondaryCoverageISC_CoverageOutput == header.fCoverageOutput) {
-            // Get (1-RGBA) into coeff
-            coeff = GrGLSLExpr4(1) - inColor;
-        }
-        // Get coeff * coverage into modulate and then write that to the dual source output.
-        builder->fsCodeAppendf("\t%s = %s;\n", secondaryOutputName, (coeff * inCoverage).c_str());
-    }
-
-    ///////////////////////////////////////////////////////////////////////////
-    // combine color and coverage as frag color
-
-    // Get "color * coverage" into fragColor
-    GrGLSLExpr4 fragColor = inColor * inCoverage;
-    // Now tack on "+(1-coverage)dst onto the frag color if we were asked to do so.
-    if (GrGLProgramDesc::kCombineWithDst_CoverageOutput == header.fCoverageOutput) {
-        GrGLSLExpr4 dstCoeff = GrGLSLExpr4(1) - inCoverage;
-
-        GrGLSLExpr4 dstContribution = dstCoeff * GrGLSLExpr4(builder->dstColor());
-
-        fragColor = fragColor + dstContribution;
-    }
-    builder->fsCodeAppendf("\t%s = %s;\n", builder->getColorOutputName(), fragColor.c_str());
-
-    if (!builder->finish(&fProgramID)) {
-        return false;
-    }
-
-    fUniformHandles.fRTHeightUni = builder->getRTHeightUniform();
-    fUniformHandles.fDstCopyTopLeftUni = builder->getDstCopyTopLeftUniform();
-    fUniformHandles.fDstCopyScaleUni = builder->getDstCopyScaleUniform();
-    fUniformHandles.fColorUni = builder->getColorUniform();
-    fUniformHandles.fCoverageUni = builder->getCoverageUniform();
-    fUniformHandles.fDstCopySamplerUni = builder->getDstCopySamplerUniform();
-    // This must be called after we set fDstCopySamplerUni above.
-    this->initSamplerUniforms();
-
-    return true;
-}
-
 void GrGLProgram::initSamplerUniforms() {
     GL_CALL(UseProgram(fProgramID));
     GrGLint texUnitIdx = 0;
     if (fUniformHandles.fDstCopySamplerUni.isValid()) {
         fUniformManager.setSampler(fUniformHandles.fDstCopySamplerUni, texUnitIdx);
         fDstCopyTexUnit = texUnitIdx++;
     }
     fColorEffects->initSamplers(fUniformManager, &texUnitIdx);
     fCoverageEffects->initSamplers(fUniformManager, &texUnitIdx);
 }
@@ skipping 162 matching lines @@
 
         GrGLfloat viewMatrix[3 * 3];
         fMatrixState.getGLMatrix<3>(viewMatrix);
         fUniformManager.setMatrix3f(fUniformHandles.fViewMatrixUni, viewMatrix);
 
         GrGLfloat rtAdjustmentVec[4];
         fMatrixState.getRTAdjustmentVec(rtAdjustmentVec);
         fUniformManager.set4fv(fUniformHandles.fRTAdjustmentUni, 1, rtAdjustmentVec);
     }
 }