Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 306203002: Remove PROHIBITS_OVERWRITING as it is subsumed by non-configurable properties. (Closed)

Created:
6 years, 6 months ago by Toon Verwaest
Modified:
6 years, 6 months ago
Reviewers:
dcarney
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove PROHIBITS_OVERWRITING as it is subsumed by non-configurable properties. v8::DontDelete is set for Unforgeable properties, so just not setting PROHIBITS_OVERWRITING should be enough. The secondary "feature" of not allowing accessors to be installed in extending objects is incorrect and confusing, given that it only applies to accessors but not to regular properties: Object.defineProperty({__proto__:window}, "location", { value: 10 }) works where Object.defineProperty({__proto__:window}, "location", { get: function() {} }) doesn't work. LOG=y R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21596

Patch Set 1 #

Patch Set 2 : Restore include/v8.h declaration to avoid dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -127 lines) Patch
M include/v8.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M src/accessors.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.h View 5 chunks +1 line, -8 lines 0 comments Download
M src/objects.cc View 4 chunks +0 lines, -46 lines 0 comments Download
M src/objects-inl.h View 3 chunks +0 lines, -18 lines 0 comments Download
M test/cctest/test-accessors.cc View 1 chunk +0 lines, -48 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL. This will require a tiny change on the blink side, which can land before ...
6 years, 6 months ago (2014-05-30 18:57:31 UTC) #1
dcarney
lgtm
6 years, 6 months ago (2014-06-02 07:00:06 UTC) #2
Toon Verwaest
6 years, 6 months ago (2014-06-02 11:02:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r21596 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698