src/api.cc - Issue 306203002: Remove PROHIBITS_OVERWRITING as it is subsumed by non-configurable properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 306203002: Remove PROHIBITS_OVERWRITING as it is subsumed by non-configurable properties. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Restore include/v8.h declaration to avoid dependencies Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index ca552fc60f6ba44140461666f730411a92de0fe4..6164cf7fe85a670acea8462f3d63659de0a7aed6 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -1144,7 +1144,6 @@ static i::Handle<i::AccessorInfo> SetAccessorInfoProperties(

obj->set_name(*Utils::OpenHandle(*name));

if (settings & ALL_CAN_READ) obj->set_all_can_read(true);

if (settings & ALL_CAN_WRITE) obj->set_all_can_write(true);

- if (settings & PROHIBITS_OVERWRITING) obj->set_prohibits_overwriting(true);

obj->set_property_attributes(static_cast<PropertyAttributes>(attributes));

if (!signature.IsEmpty()) {

obj->set_expected_receiver_type(*Utils::OpenHandle(*signature));

« no previous file with comments | « src/accessors.cc ('k') | src/objects.h » ('j') | no next file with comments »