include/v8.h - Issue 306203002: Remove PROHIBITS_OVERWRITING as it is subsumed by non-configurable properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/v8.h

Issue 306203002: Remove PROHIBITS_OVERWRITING as it is subsumed by non-configurable properties. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Restore include/v8.h declaration to avoid dependencies Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/v8.h

diff --git a/include/v8.h b/include/v8.h

index 7af4322b08a7ded0a760bbb3aeb2ab96420a5231..8c9f3d45e707d416c479a9780168aaf695848e2d 100644

--- a/include/v8.h

+++ b/include/v8.h

@@ -2072,11 +2072,7 @@ typedef void (*AccessorSetterCallback)(

* accessors have an explicit access control parameter which specifies

* the kind of cross-context access that should be allowed.

- * Additionally, for security, accessors can prohibit overwriting by

- * accessors defined in JavaScript. For objects that have such

- * accessors either locally or in their prototype chain it is not

- * possible to overwrite the accessor by using __defineGetter__ or

- * __defineSetter__ from JavaScript code.

+ * TODO(dcarney): Remove PROHIBITS_OVERWRITING as it is now unused.

enum AccessControl {

DEFAULT = 0,

« no previous file with comments | « no previous file | src/accessors.cc » ('j') | no next file with comments »