Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 306123008: Remove some unused state from RenderLayerStackingNode (Closed)

Created:
6 years, 6 months ago by abarth-chromium
Modified:
6 years, 6 months ago
Reviewers:
esprehn, eseidel
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink, eseidel, esprehn, ojan, Ian Vollick
Visibility:
Public.

Description

Remove some unused state from RenderLayerStackingNode No one reads this state so we can remove it. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175231

Patch Set 1 #

Patch Set 2 : Also remove ghost function #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M Source/core/rendering/RenderLayerStackingNode.h View 1 2 chunks +0 lines, -9 lines 1 comment Download
M Source/core/rendering/RenderLayerStackingNode.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
abarth-chromium
6 years, 6 months ago (2014-06-01 22:01:44 UTC) #1
abarth-chromium
https://codereview.chromium.org/306123008/diff/20001/Source/core/rendering/RenderLayerStackingNode.h File Source/core/rendering/RenderLayerStackingNode.h (left): https://codereview.chromium.org/306123008/diff/20001/Source/core/rendering/RenderLayerStackingNode.h#oldcode89 Source/core/rendering/RenderLayerStackingNode.h:89: void computePaintOrderList(PaintOrderListType, Vector<RefPtr<Node> >&); This function also has no ...
6 years, 6 months ago (2014-06-01 22:03:52 UTC) #2
esprehn
rslgtm
6 years, 6 months ago (2014-06-01 22:11:35 UTC) #3
eseidel
How are there still so many weeds in this forest?! lgtm
6 years, 6 months ago (2014-06-01 22:14:22 UTC) #4
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-01 22:35:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/306123008/20001
6 years, 6 months ago (2014-06-01 22:35:45 UTC) #6
abarth-chromium
On 2014/06/01 22:14:22, eseidel wrote: > How are there still so many weeds in this ...
6 years, 6 months ago (2014-06-01 22:36:16 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-01 23:54:16 UTC) #8
Message was sent while issue was closed. 
Change committed as 175231

Powered by Google App Engine
This is Rietveld 408576698