Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: Source/core/rendering/RenderLayerStackingNode.h

Issue 306123008: Remove some unused state from RenderLayerStackingNode (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Also remove ghost function Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/rendering/RenderLayerStackingNode.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 78
79 bool hasPositiveZOrderList() const { return posZOrderList() && posZOrderList ()->size(); } 79 bool hasPositiveZOrderList() const { return posZOrderList() && posZOrderList ()->size(); }
80 bool hasNegativeZOrderList() const { return negZOrderList() && negZOrderList ()->size(); } 80 bool hasNegativeZOrderList() const { return negZOrderList() && negZOrderList ()->size(); }
81 81
82 // FIXME: should check for dirtiness here? 82 // FIXME: should check for dirtiness here?
83 bool isNormalFlowOnly() const { return m_isNormalFlowOnly; } 83 bool isNormalFlowOnly() const { return m_isNormalFlowOnly; }
84 void updateIsNormalFlowOnly(); 84 void updateIsNormalFlowOnly();
85 bool normalFlowListDirty() const { return m_normalFlowListDirty; } 85 bool normalFlowListDirty() const { return m_normalFlowListDirty; }
86 void dirtyNormalFlowList(); 86 void dirtyNormalFlowList();
87 87
88 enum PaintOrderListType {BeforePromote, AfterPromote};
89 void computePaintOrderList(PaintOrderListType, Vector<RefPtr<Node> >&);
abarth-chromium 2014/06/01 22:03:53 This function also has no callers and no implement
90
91 void updateStackingNodesAfterStyleChange(const RenderStyle* oldStyle); 88 void updateStackingNodesAfterStyleChange(const RenderStyle* oldStyle);
92 89
93 RenderLayerStackingNode* ancestorStackingContextNode() const; 90 RenderLayerStackingNode* ancestorStackingContextNode() const;
94 RenderLayerStackingNode* ancestorStackingNode() const; 91 RenderLayerStackingNode* ancestorStackingNode() const;
95 92
96 // Gets the enclosing stacking context for this node, possibly the node 93 // Gets the enclosing stacking context for this node, possibly the node
97 // itself, if it is a stacking context. 94 // itself, if it is a stacking context.
98 RenderLayerStackingNode* enclosingStackingContextNode() { return isStackingC ontext() ? this : ancestorStackingContextNode(); } 95 RenderLayerStackingNode* enclosingStackingContextNode() { return isStackingC ontext() ? this : ancestorStackingContextNode(); }
99 96
100 RenderLayer* layer() const { return m_layer; } 97 RenderLayer* layer() const { return m_layer; }
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 // descendant nodes within the stacking context that have z-indices of 0 or greater 153 // descendant nodes within the stacking context that have z-indices of 0 or greater
157 // (auto will count as 0). m_negZOrderList holds descendants within our stac king context with negative 154 // (auto will count as 0). m_negZOrderList holds descendants within our stac king context with negative
158 // z-indices. 155 // z-indices.
159 OwnPtr<Vector<RenderLayerStackingNode*> > m_posZOrderList; 156 OwnPtr<Vector<RenderLayerStackingNode*> > m_posZOrderList;
160 OwnPtr<Vector<RenderLayerStackingNode*> > m_negZOrderList; 157 OwnPtr<Vector<RenderLayerStackingNode*> > m_negZOrderList;
161 158
162 // This list contains child nodes that cannot create stacking contexts. For now it is just 159 // This list contains child nodes that cannot create stacking contexts. For now it is just
163 // overflow layers, but that may change in the future. 160 // overflow layers, but that may change in the future.
164 OwnPtr<Vector<RenderLayerStackingNode*> > m_normalFlowList; 161 OwnPtr<Vector<RenderLayerStackingNode*> > m_normalFlowList;
165 162
166 // If this is true, then no non-descendant appears between any of our
167 // descendants in stacking order. This is one of the requirements of being
168 // able to safely become a stacking context.
169 unsigned m_descendantsAreContiguousInStackingOrder : 1;
170 unsigned m_descendantsAreContiguousInStackingOrderDirty : 1;
171
172 unsigned m_zOrderListsDirty : 1; 163 unsigned m_zOrderListsDirty : 1;
173 unsigned m_normalFlowListDirty: 1; 164 unsigned m_normalFlowListDirty: 1;
174 unsigned m_isNormalFlowOnly : 1; 165 unsigned m_isNormalFlowOnly : 1;
175 166
176 #if !ASSERT_DISABLED 167 #if !ASSERT_DISABLED
177 unsigned m_layerListMutationAllowed : 1; 168 unsigned m_layerListMutationAllowed : 1;
178 RenderLayerStackingNode* m_stackingParent; 169 RenderLayerStackingNode* m_stackingParent;
179 #endif 170 #endif
180 }; 171 };
181 172
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 213
223 private: 214 private:
224 RenderLayerStackingNode* m_stackingNode; 215 RenderLayerStackingNode* m_stackingNode;
225 bool m_previousMutationAllowedState; 216 bool m_previousMutationAllowedState;
226 }; 217 };
227 #endif 218 #endif
228 219
229 } // namespace WebCore 220 } // namespace WebCore
230 221
231 #endif // RenderLayerStackingNode_h 222 #endif // RenderLayerStackingNode_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/rendering/RenderLayerStackingNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698