Move guest lifetime management to chrome

Move guest lifetime management to chrome

Now, GuestViewBase takes full responsibility for managing the lifetime of the guest WebContents. The only signal coming from content is that indicating that the BrowserPlugin has been destroyed.

BUG=364141, 330264
TBR=jam@chromium.org for trivial browser_plugin_guest_delegate.h code deletion (w00t!)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273759

[lazyboy, 2014-05-29 19:13:58]

https://chromiumcodereview.appspot.com/306003002/diff/1/chrome/browser/guest_...
File chrome/browser/guest_view/ad_view/ad_view_guest.h (right):

https://chromiumcodereview.appspot.com/306003002/diff/1/chrome/browser/guest_...
chrome/browser/guest_view/ad_view/ad_view_guest.h:11: // An AdViewGuest is a
WebContentsObserver on the guest WebContents of a
Needs update.

https://chromiumcodereview.appspot.com/306003002/diff/1/chrome/browser/guest_...
File chrome/browser/guest_view/guest_view_base.cc (right):

https://chromiumcodereview.appspot.com/306003002/diff/1/chrome/browser/guest_...
chrome/browser/guest_view/guest_view_base.cc:43: class
GuestViewBase::EmbedderWebContentsObserver : public WebContentsObserver {
Add a note saying this observer ensures we destroy ourselves when our embedder's
WC goes away.

https://chromiumcodereview.appspot.com/306003002/diff/1/chrome/browser/guest_...
File chrome/browser/guest_view/guest_view_base.h (right):

https://chromiumcodereview.appspot.com/306003002/diff/1/chrome/browser/guest_...
chrome/browser/guest_view/guest_view_base.h:22: // the guest and relays them to
the embedder.
Add comment about this becoming a WCObserver.

https://chromiumcodereview.appspot.com/306003002/diff/1/chrome/browser/guest_...
chrome/browser/guest_view/guest_view_base.h:79: virtual void EmbedderDestroyed()
{}
Add documentation.

https://chromiumcodereview.appspot.com/306003002/diff/1/chrome/browser/guest_...
chrome/browser/guest_view/guest_view_base.h:157: class
EmbedderWebContentsObserver;
nit: newline after this line.

https://chromiumcodereview.appspot.com/306003002/diff/1/chrome/browser/guest_...
File chrome/browser/guest_view/web_view/web_view_guest.h (right):

https://chromiumcodereview.appspot.com/306003002/diff/1/chrome/browser/guest_...
chrome/browser/guest_view/web_view/web_view_guest.h:38: // A WebViewGuest is a
WebContentsObserver on the guest WebContents of a
Need to update this, WVGuest is no longer a WCObserver.

https://chromiumcodereview.appspot.com/306003002/diff/1/chrome/browser/guest_...
chrome/browser/guest_view/web_view/web_view_guest.h:129: virtual void
EmbedderDestroyed() OVERRIDE;
This is a GVBase override now, move it to separate section.

https://chromiumcodereview.appspot.com/306003002/diff/1/content/public/browse...
File content/public/browser/browser_plugin_guest_delegate.h (right):

https://chromiumcodereview.appspot.com/306003002/diff/1/content/public/browse...
content/public/browser/browser_plugin_guest_delegate.h:54: typedef
base::Callback<void()>DestructionCallback;
nit: space before DestructionCallback.

[Fady Samuel, 2014-05-29 21:21:12]

PTAL Istiaque!

https://codereview.chromium.org/306003002/diff/1/chrome/browser/guest_view/ad...
File chrome/browser/guest_view/ad_view/ad_view_guest.h (right):

https://codereview.chromium.org/306003002/diff/1/chrome/browser/guest_view/ad...
chrome/browser/guest_view/ad_view/ad_view_guest.h:11: // An AdViewGuest is a
WebContentsObserver on the guest WebContents of a
On 2014/05/29 19:13:58, lazyboy wrote:
> Needs update.

Done.

https://codereview.chromium.org/306003002/diff/1/chrome/browser/guest_view/gu...
File chrome/browser/guest_view/guest_view_base.cc (right):

https://codereview.chromium.org/306003002/diff/1/chrome/browser/guest_view/gu...
chrome/browser/guest_view/guest_view_base.cc:43: class
GuestViewBase::EmbedderWebContentsObserver : public WebContentsObserver {
On 2014/05/29 19:13:58, lazyboy wrote:
> Add a note saying this observer ensures we destroy ourselves when our
embedder's
> WC goes away.

Done.

https://codereview.chromium.org/306003002/diff/1/chrome/browser/guest_view/gu...
File chrome/browser/guest_view/guest_view_base.h (right):

https://codereview.chromium.org/306003002/diff/1/chrome/browser/guest_view/gu...
chrome/browser/guest_view/guest_view_base.h:22: // the guest and relays them to
the embedder.
On 2014/05/29 19:13:58, lazyboy wrote:
> Add comment about this becoming a WCObserver.

This almost seems like an implementation detail. I don't think it's necessary to
mention this. It can be seen by reading two lines below...

https://codereview.chromium.org/306003002/diff/1/chrome/browser/guest_view/gu...
chrome/browser/guest_view/guest_view_base.h:79: virtual void EmbedderDestroyed()
{}
On 2014/05/29 19:13:58, lazyboy wrote:
> Add documentation.

Done.

https://codereview.chromium.org/306003002/diff/1/chrome/browser/guest_view/gu...
chrome/browser/guest_view/guest_view_base.h:157: class
EmbedderWebContentsObserver;
On 2014/05/29 19:13:58, lazyboy wrote:
> nit: newline after this line.

Done.

https://codereview.chromium.org/306003002/diff/1/chrome/browser/guest_view/we...
File chrome/browser/guest_view/web_view/web_view_guest.h (right):

https://codereview.chromium.org/306003002/diff/1/chrome/browser/guest_view/we...
chrome/browser/guest_view/web_view/web_view_guest.h:38: // A WebViewGuest is a
WebContentsObserver on the guest WebContents of a
On 2014/05/29 19:13:58, lazyboy wrote:
> Need to update this, WVGuest is no longer a WCObserver.

Done.

https://codereview.chromium.org/306003002/diff/1/chrome/browser/guest_view/we...
chrome/browser/guest_view/web_view/web_view_guest.h:129: virtual void
EmbedderDestroyed() OVERRIDE;
On 2014/05/29 19:13:58, lazyboy wrote:
> This is a GVBase override now, move it to separate section.

Done.

https://codereview.chromium.org/306003002/diff/1/content/public/browser/brows...
File content/public/browser/browser_plugin_guest_delegate.h (right):

https://codereview.chromium.org/306003002/diff/1/content/public/browser/brows...
content/public/browser/browser_plugin_guest_delegate.h:54: typedef
base::Callback<void()>DestructionCallback;
On 2014/05/29 19:13:58, lazyboy wrote:
> nit: space before DestructionCallback.

Done.

[lazyboy, 2014-05-29 22:15:52]

lgtm

[Fady Samuel, 2014-05-29 23:26:18]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-05-29 23:27:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fsamuel@chromium.org/306003002/40001

[commit-bot: I haz the power, 2014-05-30 08:07:04]

Change committed as 273759