chrome/browser/guest_view/ad_view/ad_view_guest.cc - Issue 306003002: Move guest lifetime management to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/ad_view/ad_view_guest.cc

Issue 306003002: Move guest lifetime management to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed content_browsertests crash Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/guest_view/ad_view/ad_view_guest.cc

diff --git a/chrome/browser/guest_view/ad_view/ad_view_guest.cc b/chrome/browser/guest_view/ad_view/ad_view_guest.cc

index dd6b586cd42c45ba8f4dcb6ce384baedd15bf699..5144729626aa7832c6e833c6c0ebe5cf971163f9 100644

--- a/chrome/browser/guest_view/ad_view/ad_view_guest.cc

+++ b/chrome/browser/guest_view/ad_view/ad_view_guest.cc

@@ -17,8 +17,7 @@ AdViewGuest::AdViewGuest(int guest_instance_id,

const std::string& extension_id)

: GuestView<AdViewGuest>(guest_instance_id,

guest_web_contents,

- extension_id),

- WebContentsObserver(guest_web_contents) {

+ extension_id) {

}

// static