Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3047)

Unified Diff: chrome/browser/guest_view/ad_view/ad_view_guest.h

Issue 306003002: Move guest lifetime management to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed content_browsertests crash Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/guest_view/ad_view/ad_view_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/guest_view/ad_view/ad_view_guest.h
diff --git a/chrome/browser/guest_view/ad_view/ad_view_guest.h b/chrome/browser/guest_view/ad_view/ad_view_guest.h
index 02bbbf58afceb3bb55f56c230f8080d96e0e4a9b..89a4229cac0a98668967002188f110c75429d140 100644
--- a/chrome/browser/guest_view/ad_view/ad_view_guest.h
+++ b/chrome/browser/guest_view/ad_view/ad_view_guest.h
@@ -7,17 +7,14 @@
#include "base/values.h"
#include "chrome/browser/guest_view/guest_view.h"
-#include "content/public/browser/web_contents_observer.h"
-// An AdViewGuest is a WebContentsObserver on the guest WebContents of a
-// <adview> tag. It provides the browser-side implementation of the <adview>
-// API and manages the lifetime of <adview> extension events. AdViewGuest is
-// created on attachment. When a guest WebContents is associated with
-// a particular embedder WebContents, we call this "attachment".
+// An AdViewGuest provides the browser-side implementation of the <adview> API
+// and manages the dispatch of <adview> extension events. AdViewGuest is created
+// on attachment. When a guest WebContents is associated with a particular
+// embedder WebContents, we call this "attachment".
// TODO(fsamuel): There might be an opportunity here to refactor and reuse code
// between AdViewGuest and WebViewGuest.
-class AdViewGuest : public GuestView<AdViewGuest>,
- public content::WebContentsObserver {
+class AdViewGuest : public GuestView<AdViewGuest> {
public:
AdViewGuest(int guest_instance_id,
content::WebContents* guest_web_contents,
« no previous file with comments | « no previous file | chrome/browser/guest_view/ad_view/ad_view_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698