DevTools: Add parent id to target descriptor in remote debugging.

DevTools: Add parent id to target descriptor in remote debugging.

Webviews and OOP iframes now have non-empty parentId property pointing to the target they are nested into. Also added 'webview' and 'iframe' target types.

TBR=bulach,mnaganov (for dev_tools_server.cc aw_dev_tools_server.cc)
BUG=378457
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274178

[Dmitry Zvorygin, 2014-05-29 13:03:12]

LGTM with nits.

https://chromiumcodereview.appspot.com/305903004/diff/1/content/browser/devto...
File content/browser/devtools/devtools_http_handler_impl.cc (right):

https://chromiumcodereview.appspot.com/305903004/diff/1/content/browser/devto...
content/browser/devtools/devtools_http_handler_impl.cc:57: const char
kTargetParentIdField[] = "parent_id";
"parentId" would fit naming conventions better.

[Vladislav Kaznacheev, 2014-05-29 17:28:29]

https://chromiumcodereview.appspot.com/305903004/diff/1/content/browser/devto...
File content/browser/devtools/devtools_http_handler_impl.cc (right):

https://chromiumcodereview.appspot.com/305903004/diff/1/content/browser/devto...
content/browser/devtools/devtools_http_handler_impl.cc:57: const char
kTargetParentIdField[] = "parent_id";
On 2014/05/29 13:03:12, Dmitry Zvorygin wrote:
> "parentId" would fit naming conventions better.

Done.

[Vladislav Kaznacheev, 2014-05-29 17:28:41]

The CQ bit was checked by kaznacheev@chromium.org

[commit-bot: I haz the power, 2014-05-29 17:32:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/305903004/20001

[commit-bot: I haz the power, 2014-05-29 20:13:10]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-05-29 20:21:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-29 20:21:19]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Vladislav Kaznacheev, 2014-05-30 09:15:02]

Hi John,

Please review content/public/browser/devtools_target.h

Thanks!

  Vlad

[jam, 2014-05-30 19:18:25]

On 2014/05/30 09:15:02, Vladislav Kaznacheev wrote:
> Hi John,
> 
> Please review content/public/browser/devtools_target.h
> 
> Thanks!
> 
>   Vlad

lgtm

[Vladislav Kaznacheev, 2014-05-31 18:41:12]

The CQ bit was checked by kaznacheev@chromium.org

[commit-bot: I haz the power, 2014-05-31 18:56:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/305903004/40001

[commit-bot: I haz the power, 2014-05-31 20:38:43]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-05-31 20:40:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-31 20:40:48]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Vladislav Kaznacheev, 2014-06-02 06:46:50]

The CQ bit was checked by kaznacheev@chromium.org

[commit-bot: I haz the power, 2014-06-02 06:46:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/305903004/40001

[commit-bot: I haz the power, 2014-06-02 07:33:47]

Change committed as 274178