android_webview/native/aw_dev_tools_server.cc - Issue 305903004: DevTools: Add parent id to target descriptor in remote debugging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_dev_tools_server.cc

Issue 305903004: DevTools: Add parent id to target descriptor in remote debugging. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed WebView compile Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/native/aw_dev_tools_server.cc

diff --git a/android_webview/native/aw_dev_tools_server.cc b/android_webview/native/aw_dev_tools_server.cc

index ab08ca5472936e03f01582a3fcded66cdbeac594..35b645573136dac0c7cda295ae7ab06bc56be813 100644

--- a/android_webview/native/aw_dev_tools_server.cc

+++ b/android_webview/native/aw_dev_tools_server.cc

@@ -39,6 +39,7 @@ class Target : public content::DevToolsTarget {

explicit Target(WebContents* web_contents);

virtual std::string GetId() const OVERRIDE { return id_; }

+ virtual std::string GetParentId() const OVERRIDE { return std::string(); }

virtual std::string GetType() const OVERRIDE { return kTargetTypePage; }

virtual std::string GetTitle() const OVERRIDE { return title_; }

virtual std::string GetDescription() const OVERRIDE { return description_; }

« no previous file with comments | « no previous file | chrome/browser/android/dev_tools_server.cc » ('j') | no next file with comments »