Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: content/shell/browser/shell_devtools_delegate.cc

Issue 305903004: DevTools: Add parent id to target descriptor in remote debugging. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed WebView compile Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/browser/devtools_target.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/shell/browser/shell_devtools_delegate.h" 5 #include "content/shell/browser/shell_devtools_delegate.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 } 70 }
71 return new net::TCPListenSocketFactory("127.0.0.1", port); 71 return new net::TCPListenSocketFactory("127.0.0.1", port);
72 #endif 72 #endif
73 } 73 }
74 74
75 class Target : public content::DevToolsTarget { 75 class Target : public content::DevToolsTarget {
76 public: 76 public:
77 explicit Target(WebContents* web_contents); 77 explicit Target(WebContents* web_contents);
78 78
79 virtual std::string GetId() const OVERRIDE { return id_; } 79 virtual std::string GetId() const OVERRIDE { return id_; }
80 virtual std::string GetParentId() const OVERRIDE { return std::string(); }
80 virtual std::string GetType() const OVERRIDE { return kTargetTypePage; } 81 virtual std::string GetType() const OVERRIDE { return kTargetTypePage; }
81 virtual std::string GetTitle() const OVERRIDE { return title_; } 82 virtual std::string GetTitle() const OVERRIDE { return title_; }
82 virtual std::string GetDescription() const OVERRIDE { return std::string(); } 83 virtual std::string GetDescription() const OVERRIDE { return std::string(); }
83 virtual GURL GetURL() const OVERRIDE { return url_; } 84 virtual GURL GetURL() const OVERRIDE { return url_; }
84 virtual GURL GetFaviconURL() const OVERRIDE { return favicon_url_; } 85 virtual GURL GetFaviconURL() const OVERRIDE { return favicon_url_; }
85 virtual base::TimeTicks GetLastActivityTime() const OVERRIDE { 86 virtual base::TimeTicks GetLastActivityTime() const OVERRIDE {
86 return last_activity_time_; 87 return last_activity_time_;
87 } 88 }
88 virtual bool IsAttached() const OVERRIDE { 89 virtual bool IsAttached() const OVERRIDE {
89 return agent_host_->IsAttached(); 90 return agent_host_->IsAttached();
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 } 207 }
207 208
208 scoped_ptr<net::StreamListenSocket> 209 scoped_ptr<net::StreamListenSocket>
209 ShellDevToolsDelegate::CreateSocketForTethering( 210 ShellDevToolsDelegate::CreateSocketForTethering(
210 net::StreamListenSocket::Delegate* delegate, 211 net::StreamListenSocket::Delegate* delegate,
211 std::string* name) { 212 std::string* name) {
212 return scoped_ptr<net::StreamListenSocket>(); 213 return scoped_ptr<net::StreamListenSocket>();
213 } 214 }
214 215
215 } // namespace content 216 } // namespace content
OLDNEW
« no previous file with comments | « content/public/browser/devtools_target.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698