Chromium Code Reviews Chromium Code Reviews
Issue
305823003:
Re-land: Defer SpdySession destruction to support closing writes (Closed)
DescriptionDefer SpdySession destruction to support closing writes
Replace the STATE_CLOSED availability state with STATE_DRAINING, where:
* The read-pump will not run, and no frames can be read.
* No new frames may be queued in the sessions's write_queue.
* However, the write-pump will continue to run.
SpdySession's write-pump will destroy the session iff it's draining, the
write queue is empty and no in-flight writes remain. As this (and
~SpdySessionPool()) are now the only locations where SpdySessions may be
destroyed, session lifetime is more know-able and some WeakPtrs are
removed.
Some tests have been updated to include closing RST_STREAMS sent by the
session. This reflects current behavior. A future CL will add GOAWAY
frames upon session errors.
BUG=375033, 379469
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273680
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275005
Patch Set 1 #Patch Set 2 : Update remaining SpdyProxyClientSocketTests which need to run MessageLoop to let RST_STREAM write. #Patch Set 3 : Regression tests and fix for crbug.com/379469 #
Messages
Total messages: 13 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
