net/spdy/spdy_network_transaction_unittest.cc - Issue 305823003: Re-land: Defer SpdySession destruction to support closing writes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_network_transaction_unittest.cc

Issue 305823003: Re-land: Defer SpdySession destruction to support closing writes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Regression tests and fix for crbug.com/379469 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_network_transaction_unittest.cc

diff --git a/net/spdy/spdy_network_transaction_unittest.cc b/net/spdy/spdy_network_transaction_unittest.cc

index 1ecbc3993993aa6b081d3ab0aad6700dddcd0aa8..dd1f489afe50609224af63288a1af6a3881bb8bf 100644

--- a/net/spdy/spdy_network_transaction_unittest.cc

+++ b/net/spdy/spdy_network_transaction_unittest.cc

@@ -4271,7 +4271,9 @@ TEST_P(SpdyNetworkTransactionTest, BufferedCancelled) {

scoped_ptr<SpdyFrame> req(

spdy_util_.ConstructSpdyGet(NULL, 0, false, 1, LOWEST, true));

- MockWrite writes[] = { CreateMockWrite(*req) };

+ scoped_ptr<SpdyFrame> rst(

+ spdy_util_.ConstructSpdyRstStream(1, RST_STREAM_CANCEL));

+ MockWrite writes[] = {CreateMockWrite(*req), CreateMockWrite(*rst)};

// NOTE: We don't FIN the stream.

scoped_ptr<SpdyFrame> data_frame(

« no previous file with comments | « net/http/http_stream_factory_impl_request.cc ('k') | net/spdy/spdy_proxy_client_socket.cc » ('j') | no next file with comments »