net/spdy/spdy_proxy_client_socket.cc - Issue 305823003: Re-land: Defer SpdySession destruction to support closing writes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_proxy_client_socket.cc

Issue 305823003: Re-land: Defer SpdySession destruction to support closing writes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Regression tests and fix for crbug.com/379469 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_proxy_client_socket.cc

diff --git a/net/spdy/spdy_proxy_client_socket.cc b/net/spdy/spdy_proxy_client_socket.cc

index 74e6d7489ebe75c13df80e048dd1441833797b33..5eb8d99335e532e62f2365c59b20576bf5ac12f6 100644

--- a/net/spdy/spdy_proxy_client_socket.cc

+++ b/net/spdy/spdy_proxy_client_socket.cc

@@ -410,6 +410,7 @@ int SpdyProxyClientSocket::DoReadReplyComplete(int result) {

if (SanitizeProxyRedirect(&response_, request_.url)) {

redirect_has_load_timing_info_ =

spdy_stream_->GetLoadTimingInfo(&redirect_load_timing_info_);

+ // Note that this triggers a RST_STREAM_CANCEL.

spdy_stream_->DetachDelegate();

next_state_ = STATE_DISCONNECTED;

return ERR_HTTPS_PROXY_TUNNEL_RESPONSE;